Add support for Python 3.15 by hsorby · Pull Request #1471 · cellml/libcellml

hsorby · 2026-09-25T10:13:47Z

Fixes Support python 3.15 #1462.

Adds support for Python 3.15 by building wheels against the stable API.

Copilot

Copilot review overview

🟡 Changes recommended

Windows wheels omit a required repair step, and Python 3.15 compatibility is not tested.

Review effort: Balanced
Findings: 1 · 1 · 2

Open (4)

Disabling Windows wheel repair omits the required cellml.dll · New
Add CI validation for advertised Python 3.15 support · New
Update documented CMake minimum version to 3.26 · New
Remove unused duplicate setup script · New

What changed in this PR

Adds Python 3.15 compatibility by producing CPython 3.10 stable-ABI wheels.

Changes:

Enables abi3 compilation and wheel tagging.
Updates Python/CMake discovery for stable-ABI modules.
Consolidates release builds into per-platform stable-ABI wheels.

File	Description
`src/bindings/python/pyproject.toml`	Configures CPython 3.10 stable-ABI tagging.
`src/bindings/python/CMakeLists.txt`	Enables the limited Python API.
`src/bindings/python/cibuildwheel.setup.py`	Adds duplicate legacy packaging configuration.
`CMakeLists.txt`	Raises the minimum CMake version.
`cmake/environmentchecks.cmake`	Detects and selects stable-ABI linking support.
`.github/workflows/deploy-on-release.yml`	Builds and publishes platform-specific ABI3 wheels.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

The SWIG minimum and version-specific Python-link fallback can produce wheels that fail under Python 3.15.

Review effort: Balanced
Findings: 2

Open (2)

Avoid Python::Module fallback in stable-ABI builds · New
Require SWIG 4.4+ for Python 3.15-compatible wheels · New

Resolved since last review (4)

Disabling Windows wheel repair omits the required cellml.dll
Add CI validation for advertised Python 3.15 support
Remove unused duplicate setup script
Update documented CMake minimum version to 3.26

…he catch of creating stable ABI wheels and older SWIGs.

Copilot

Copilot review overview

🟡 Changes recommended

The SWIG guidance incorrectly suggests older generated bindings can support Python 3.15.

Review effort: Balanced
Findings: 1

Open (1)

Clarify SWIG 4.4 requirement for Python 3.15+ bindings · New

Resolved since last review (2)

Require SWIG 4.4+ for Python 3.15-compatible wheels
Avoid Python::Module fallback in stable-ABI builds

Copilot

Copilot review overview

🟡 Changes recommended

Limited-API compilation currently breaks the documented SWIG 3.0.12 build path.

Review effort: Balanced
Findings: 1

Open (1)

Unconditionally enabling limited API breaks SWIG 3 builds · New

Resolved since last review (1)

Clarify SWIG 4.4 requirement for Python 3.15+ bindings

Copilot

Copilot review overview

🟡 Changes recommended

The fallback can mislabel version-specific binaries as ABI3, and the SWIG and Python compatibility changes are inconsistent with documented support.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Unconditionally enabling limited API breaks SWIG 3 builds
SWIG 3.x is rejected despite documented local-build support · New

Previously missed (1)

In code that hasn't changed since last review

cp310 ABI floor unexpectedly drops Python 3.9 wheel support

src/bindings/python/pyproject.toml:37

Using cp310 as the ABI floor removes Python 3.9 wheel support, although the previous release matrix explicitly produced 3.9 wheels on supported platforms. The PR is described only as adding Python 3.15 support, so this is an unannounced compatibility break. Either retain 3.9 with a matching limited-API floor if the generated bindings permit it, or explicitly document the dropped Python version as part of this change.

Copilot

Copilot review overview

🔵 Needs a closer look

Wheel builds can still receive an abi3 tag when stable-ABI development support was not found.

Review effort: Balanced
Findings: 1 · 1

Open (2)

Unconditionally enabling limited API breaks SWIG 3 builds
SWIG 3.x is rejected despite documented local-build support

Copilot

Copilot review overview

🔵 Needs a closer look

The WebAssembly documentation still advertises an unsupported CMake minimum.

Review effort: Balanced
Findings: None

Resolved since last review (2)

Unconditionally enabling limited API breaks SWIG 3 builds
SWIG 3.x is rejected despite documented local-build support

Copilot

🔵 Needs a closer look

Multi-platform binary ABI and release-pipeline changes warrant final human validation.

0 open findings

Previously missed (1)

In code that hasn't changed since last review

Remove unused Python development platform branch

cmake/environmentchecks.cmake:38

This replacement leaves _FIND_PYTHON_DEVELOPMENT_TYPE and FIND_PYTHON_DEVELOPMENT_MODULE above completely unused. Remove that obsolete platform branch so future changes do not imply that Python discovery still varies by platform.

🧠 Review effort: Balanced

Removed conditional checks for Python development type based on CMake version and system name.

Copilot

🔵 Needs a closer look

The cross-platform stable-ABI release path is not exercised by the available pull-request checks and requires final human validation.

0 open findings

🧠 Review effort: Balanced

hsorby added 4 commits September 22, 2026 10:57

Create stable ABI wheels for distribution.

4036dac

Clean up CMake code.

2b23733

Check for correct component of Python found.

3d9bab4

Merge in changes from prime/main fixing conflicts.

fcd6abc

hsorby added the Infrastructure Building, hosting, testing, etc. label Sep 25, 2026

hsorby requested a review from agarny September 25, 2026 10:29

agarny reviewed Sep 25, 2026

View reviewed changes

Comment thread .github/workflows/deploy-on-release.yml Outdated

Comment thread .github/workflows/deploy-on-release.yml

Comment thread .github/workflows/deploy-on-release.yml

hsorby added 2 commits September 25, 2026 23:01

Update labels for Python wheels step names in deploy workflow.

0557a2b

Merge branch 'main' into 1462-py315

a17f6ea

hsorby requested review from agarny and a balanced review from Copilot September 30, 2026 09:23

Copilot started reviewing on behalf of hsorby September 30, 2026 09:23

View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread .github/workflows/deploy-on-release.yml

Comment thread .github/workflows/deploy-on-release.yml

Comment thread CMakeLists.txt

Comment thread src/bindings/python/cibuildwheel.setup.py Outdated

hsorby added 3 commits September 30, 2026 22:33

Delete src/bindings/python/cibuildwheel.setup.py

9d1a901

Update documenation to mention that 3.26 is the minimum version.

11c6683

Merge branch '1462-py315' of github.com:hsorby/libcellml into 1462-py315

3f9e578

hsorby requested a balanced review from Copilot September 30, 2026 09:38

Copilot started reviewing on behalf of hsorby September 30, 2026 09:38

View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread cmake/environmentchecks.cmake

Comment thread src/bindings/python/CMakeLists.txt Outdated

hsorby added 2 commits October 2, 2026 15:02

Only code to the stable API if the stable API module is found.

aebc5ae

Add a note in the versions documentation to inform developers about t…

f5c303c

…he catch of creating stable ABI wheels and older SWIGs.

hsorby requested a balanced review from Copilot October 2, 2026 02:31

Copilot started reviewing on behalf of hsorby October 2, 2026 02:31

View session

Fix typo in preferable.

1eb3e01

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Comment thread docs/versions.rst Outdated

Clarify SWIG version in versions.rst.

3dcb35a

hsorby requested a balanced review from Copilot October 2, 2026 02:44

Copilot started reviewing on behalf of hsorby October 2, 2026 02:44

View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Comment thread src/bindings/python/CMakeLists.txt

Make SWIG version 4 the minimum required SWIG.

817b04b

hsorby requested a balanced review from Copilot October 5, 2026 06:13

Copilot started reviewing on behalf of hsorby October 5, 2026 06:14

View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Comment thread cmake/environmentchecks.cmake

hsorby added 2 commits October 5, 2026 19:21

Update versions.rst with SWIG version supported.

584b8f8

Fix typo in versions.rst.

dca289c

hsorby requested a balanced review from Copilot October 5, 2026 06:27

Copilot started reviewing on behalf of hsorby October 5, 2026 06:28

View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

hsorby requested a balanced review from Copilot October 5, 2026 22:48

Copilot started reviewing on behalf of hsorby October 5, 2026 22:49

View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

Update web assembly documentation to match build CMake version.

43cc1a5

hsorby requested a balanced review from Copilot October 13, 2026 07:52

Copilot started reviewing on behalf of hsorby October 13, 2026 07:52

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

Simplify Python development checks in CMake

b7ec72f

Removed conditional checks for Python development type based on CMake version and system name.

hsorby requested a balanced review from Copilot October 13, 2026 08:31

Copilot started reviewing on behalf of hsorby October 13, 2026 08:32

View session

Copilot AI reviewed Oct 13, 2026

View reviewed changes

hsorby added 2 commits October 13, 2026 21:50

Merge branch 'main' into 1462-py315

9ea77e4

Merge branch 'main' into 1462-py315

899d064

Conversation

hsorby commented Sep 25, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants